London | Funmi Moriyele | Wireframe Task | Week 2 #206
+99
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fmoriyele
changed the title
SallyMcGrath
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Hi @fmoriyele . Thanks for this! Your work is deployed here https://deploy-preview-206--cyf-ufd.netlify.app/wireframe/
-
When I ran Lighthouse it scored 83. Run Lighthouse yourself and make the suggested changes until your score is 100
-
Regarding your question. You don't need this div and it's complicating your code (nearly always in HTML and CSS the answer is to remove code) . Put all three articles as child of main and then try assigning a style to article:first-child .
https://developer.mozilla.org/en-US/docs/Web/CSS/:first-child
SallyMcGrath
added
👀 Review Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
✓ I have committed my files one by one, on purpose, and for a reason
✓ I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
✓ I have tested my changes
✓ My changes follow the style guide
✓ My changes meet the requirements of this task
Changelist
✓ I have created a webpage about Git that contains three articles. I used HTML5, CSS3, and Web Design to develop this webpage.
Questions
I struggled to use the :first-class pseudo class. I applied this to Article 1, creating a
<div class="article-section">to make sure Article 1 is the first child of the parent container. However, it seems to make no changes to the code when I use css to style it.I would appreciate any feedback on how to correct this.
Thank you for reviewing!